Skip to content

enable colors#2921

Closed
vivekkhimani wants to merge 3 commits intoNetflix:masterfrom
vivekkhimani:vivek/click-color-changes
Closed

enable colors#2921
vivekkhimani wants to merge 3 commits intoNetflix:masterfrom
vivekkhimani:vivek/click-color-changes

Conversation

@vivekkhimani
Copy link
Copy Markdown
Contributor

@vivekkhimani vivekkhimani commented Feb 25, 2026

PR Type

  • Bug fix
  • New feature
  • Core Runtime change (higher bar -- see CONTRIBUTING.md)
  • Docs / tooling
  • Refactoring

Summary

Issue

Fixes #2797

Reproduction

Runtime:

Commands to run:

# paste exact commands

Where evidence shows up:

Before (error / log snippet)
paste here
After (evidence that fix works)
paste here

Root Cause

Why This Fix Is Correct

Failure Modes Considered

Tests

  • Unit tests added/updated
  • Reproduction script provided (required for Core Runtime)
  • CI passes
  • If tests are impractical: explain why below and provide manual evidence above

Non-Goals

AI Tool Usage

  • No AI tools were used in this contribution
  • AI tools were used (describe below)

@npow npow closed this Mar 12, 2026
@npow npow reopened this Mar 12, 2026
@vivekkhimani
Copy link
Copy Markdown
Contributor Author

closing this for now but will revisit this once i have some bandwidth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendored Click's isatty() ignores FORCE_COLOR, stripping all ANSI codes from step subprocess output

2 participants